Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added extra cli flag webhook-port #899

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Added extra cli flag webhook-port #899

merged 2 commits into from
Jun 1, 2022

Conversation

abelperezok
Copy link
Contributor

@abelperezok abelperezok commented May 29, 2022 •
edited
Loading

This PR is related to the following issues:

It includes a new CLI flag webhook-port to allow the user to select a different port in case the default 9443 is already in use by another cluster add-on.

The second commit fixes a typo in the code that prevented the correct use of the CLI flag health-probe-addr, before the change, you'll get the following error if you attempt to pass the flag.

unknown flag: --health-probe-addr

@abelperezok abelperezok requested a review from a team May 29, 2022 13:42
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 29, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: abelperezok / name: Abel Perez Martinez (4fa2405)

@abelperezok abelperezok mentioned this pull request May 29, 2022
Closed
@abelperezok abelperezok mentioned this pull request May 29, 2022
Merged
@abelperezok
Copy link
Contributor Author

I had a look at the failed e2e tests logs and it looks like a transient error:

go: github.com/docker/[email protected]: read tcp 172.17.0.2:45116->142.250.136.141:443: read: connection reset by peer
The command '/bin/sh -c go mod download' returned a non-zero code: 1
make: *** [Makefile:181: container-target-allocator] Error 1

Could this be retried ?

Another question: should this change justify a bump in either patch number or minor number version ?

@yuriolisa
Copy link
Contributor

@abelperezok, I just restarted the tests.

yuriolisa
yuriolisa approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@yuriolisa yuriolisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @abelperezok for your PR! LGTM!

@pavolloffay pavolloffay merged commit e28a2ce into open-telemetry:main Jun 1, 2022
@yuriolisa yuriolisa mentioned this pull request Jun 1, 2022
Closed
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
@abelperezok
Added extra cli flag webhook-port (open-telemetry#899)
28848c4 
* Added extra cli flag webhook-port

* Fixed typo preventing the use of the cli flag health-probe-addr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriolisa yuriolisa yuriolisa approved these changes

@pavolloffay pavolloffay pavolloffay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abelperezok @yuriolisa @pavolloffay